Support remote action cache for nested local execution#2031
Merged
abderrahim merged 8 commits intomasterfrom Jul 11, 2025
Merged
Support remote action cache for nested local execution#2031abderrahim merged 8 commits intomasterfrom
abderrahim merged 8 commits intomasterfrom
Conversation
This was referenced Jul 4, 2025
juergbi
force-pushed
the
jbilleter/action-cache
branch
from
5bc5aad to
e4ed456
Compare
juergbi
requested review from
BenjaminSchubert,
abderrahim,
cs-shadow and
gtristan
as code owners
juergbi
force-pushed
the
jbilleter/action-cache
branch
from
e4ed456 to
cb73060
Compare
abderrahim
approved these changes
Jul 6, 2025
Contributor
abderrahim
left a comment
abderrahim
left a comment
There was a problem hiding this comment.
Looks good. I have a few comments and questions, but nothing that I would consider a blocker.
This makes it possible to drop the fallback to direct connections to remote servers.
Without direct gRPC connections to remote servers, these cleanup methods are no longer needed.
This is the latest protobuf version before protobuf 6, which includes breaking changes. protobuf 5.29 is supported until 31 Mar 2026.
juergbi
force-pushed
the
jbilleter/action-cache
branch
from
cb73060 to
be20044
Compare
abderrahim
reviewed
Jul 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This generalizes the
remote-executionconfig section to support using the Remote Execution API while still using local execution, only using the CAS and Action Cache services of the REAPI. I.e., this allows aremote-executionconfig section withaction-cache-servicealso if noexecution-serviceis configured.This branch supports a remote action cache with local execution only for nested REAPI clients using the remote execution protocol. Using an action cache (local or remote) also for BuildStream build jobs is not implemented in this branch but is planned for a follow-up.
This requires buildbox-casd master or 1.3.23 (should be released early next week).